From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751510AbdG0Juw (ORCPT ); Thu, 27 Jul 2017 05:50:52 -0400 Received: from mail-pf0-f193.google.com ([209.85.192.193]:33666 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750878AbdG0Jut (ORCPT ); Thu, 27 Jul 2017 05:50:49 -0400 Date: Thu, 27 Jul 2017 18:51:01 +0900 From: Sergey Senozhatsky To: Petr Mladek Cc: Sergey Senozhatsky , Sergey Senozhatsky , Steven Rostedt , Andrew Morton , Peter Zijlstra , Matt Redfearn , Greg Kroah-Hartman , Jiri Slaby , "David S. Miller" , Alan Cox , "Fabio M. Di Nitto" , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] printk/console: Enhance the check for consoles using init memory Message-ID: <20170727095100.GA653@jagdpanzerIV.localdomain> References: <1500036673-7122-1-git-send-email-pmladek@suse.com> <1500036673-7122-3-git-send-email-pmladek@suse.com> <20170726130804.GB2173@jagdpanzerIV.localdomain> <20170727092957.GD3799@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170727092957.GD3799@pathway.suse.cz> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On (07/27/17 11:29), Petr Mladek wrote: [..] > > > Signed-off-by: Petr Mladek > > > > Reviewed-by: Sergey Senozhatsky > > Thanks for the review. I am going to push the two patches into > for-4.14 branch so that we could get some testing via linux-next. good. agree. how do you think, would pr_warn() be enough for people to notice the wrongdoing or shall we put WARN_ON() there for a while at least? (assuming that people pay more attention to backtraces). -ss