From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751579AbdG0KYw (ORCPT ); Thu, 27 Jul 2017 06:24:52 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:44430 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750997AbdG0KYv (ORCPT ); Thu, 27 Jul 2017 06:24:51 -0400 Date: Thu, 27 Jul 2017 11:24:58 +0100 From: Will Deacon To: Thomas Gleixner Cc: LKML , Marc Zyngier , Russell King , LAK Subject: Re: [PATCH] genirq/cpuhotplug: Revert "Set force affinity flag on hotplug migration" Message-ID: <20170727102458.GB20746@arm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Thanks Thomas, this should fix our nightly testing which is currently failing the CPU hotplug tests. On Thu, Jul 27, 2017 at 12:21:11PM +0200, Thomas Gleixner wrote: > --- a/kernel/irq/cpuhotplug.c > +++ b/kernel/irq/cpuhotplug.c > @@ -95,8 +95,13 @@ static bool migrate_one_irq(struct irq_d > affinity = cpu_online_mask; > brokeaff = true; > } > - > - err = irq_do_set_affinity(d, affinity, true); > + /* > + * Do not set the force argument of irq_do_set_affinity() as this > + * disables the masking of offline CPUs from the supplied affinity > + * mask and therefor might keep/reassign the irq to the outgoing Typo: therefore > + * CPU. > + */ > + err = irq_do_set_affinity(d, affinity, false); With that fixed: Acked-by: Will Deacon Cheers, Will