From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751717AbdG0TYd (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Jul 2017 15:24:33 -0400
Received: from mail-qt0-f176.google.com ([209.85.216.176]:36668 "EHLO
        mail-qt0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751461AbdG0TYb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Jul 2017 15:24:31 -0400
Date: Thu, 27 Jul 2017 15:24:27 -0400
From: Tejun Heo <tj@kernel.org>
To: Michael Bringmann <mwb@linux.vnet.ibm.com>
Cc: Nathan Fontenot <nfont@linux.vnet.ibm.com>,
        Lai Jiangshan <jiangshanlai@gmail.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6] workqueue: Fix edge cases for calc of pool's cpumask
Message-ID: <20170727192427.GJ742618@devbig577.frc2.facebook.com>
References: <5c421712-fb38-3020-d3fc-b9bdea792cd3@linux.vnet.ibm.com>
 <47ac4fb9-a316-0125-7d4e-73cf602d891e@linux.vnet.ibm.com>
 <a7215815-66f9-6344-4b8c-c9f0bff4099d@linux.vnet.ibm.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <a7215815-66f9-6344-4b8c-c9f0bff4099d@linux.vnet.ibm.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jul 27, 2017 at 02:12:52PM -0500, Michael Bringmann wrote:
> 
> >>
> >>  	/* yeap, return possible CPUs in @node that @attrs wants */
> >>  	cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
> >> +
> >> +	if (cpumask_empty(cpumask)) {
> >> +		pr_warn_once("WARNING: workqueue cpumask: onl intersect > "
> >                                                           ^^^
> > This message doesn't seem right, or I am missing something, "onl"?
> 
> Shorthand for 'online' in long message.

Let's please spell it out.

Thanks.

-- 
tejun