From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751782AbdG1K3h (ORCPT ); Fri, 28 Jul 2017 06:29:37 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18405 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751606AbdG1K3g (ORCPT ); Fri, 28 Jul 2017 06:29:36 -0400 Date: Fri, 28 Jul 2017 13:29:16 +0300 From: Dan Carpenter To: janani-sankarababu Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, adrien.descamps@gmail.com, sergio.paracuellos@gmail.com, davem@davemloft.net Subject: Re: [PATCH] drivers:staging:wlan-ng Correct multiple line dereference Message-ID: <20170728102916.clog3m3lajfebuju@mwanda> References: <1501236207-27677-1-git-send-email-jananis37@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501236207-27677-1-git-send-email-jananis37@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix your email From header to match your Signed-off-by line. The subject should be: [PATCH] staging: wlan-ng: Correct multiple line dereference On Fri, Jul 28, 2017 at 03:33:27PM +0530, janani-sankarababu wrote: > This patch fixes multiple line dereference Warning reported by checkpath script. This has been made to simplify the code and make it more readable. Break this line up at the 70 character mark. > > Signed-off-by: Janani S Use your full legal name as if you were signing a legal document to certify that you haven't stolen this code from Darl McBride. > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > > diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c > index ee5fa86..2fc5f3e 100644 > --- a/drivers/staging/wlan-ng/hfa384x_usb.c > +++ b/drivers/staging/wlan-ng/hfa384x_usb.c > @@ -1345,15 +1345,13 @@ static int hfa384x_usbctlx_complete_sync(struct hfa384x *hw, > kfree(ctlx); > } else if (mode == DOWAIT) { > struct usbctlx_cmd_completor completor; > + struct usbctlx_completor *cmplt; > + > + cmplt = init_cmd_completor(&completor, &ctlx->inbuf.cmdresp, > + &cmd->result); > > result = > - hfa384x_usbctlx_complete_sync(hw, ctlx, > - init_cmd_completor(&completor, > - &ctlx-> > - inbuf. > - cmdresp, > - &cmd-> > - result)); > + hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt); Move this to the previous line: result = hfa384x_usbctlx_complete_sync(hw, ctlx, cmplt); Also the patch got corrupted by your email client so it can't apply. Read Documentation/process/email-clients.rst But generally this is a nice little cleanup. Please resend a v2 version. regards, dan carpenter