From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbdG1MBs (ORCPT ); Fri, 28 Jul 2017 08:01:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:59841 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751071AbdG1MBr (ORCPT ); Fri, 28 Jul 2017 08:01:47 -0400 Date: Fri, 28 Jul 2017 14:01:42 +0200 From: Michal Hocko To: linux-mm@kvack.org Cc: Andrew Morton , Mel Gorman , Vlastimil Babka , Andrea Arcangeli , Jerome Glisse , Reza Arbab , Yasuaki Ishimatsu , qiuxishi@huawei.com, Kani Toshimitsu , slaoub@gmail.com, Joonsoo Kim , Andi Kleen , Daniel Kiper , Igor Mammedov , Vitaly Kuznetsov , LKML , Benjamin Herrenschmidt , Catalin Marinas , Dan Williams , Fenghua Yu , Heiko Carstens , "H. Peter Anvin" , Ingo Molnar , Martin Schwidefsky , Michael Ellerman , Paul Mackerras , Thomas Gleixner , Tony Luck , Will Deacon Subject: Re: [RFC PATCH 0/5] mm, memory_hotplug: allocate memmap from hotadded memory Message-ID: <20170728120141.GK2274@dhcp22.suse.cz> References: <20170726083333.17754-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170726083333.17754-1-mhocko@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 26-07-17 10:33:28, Michal Hocko wrote: [...] > There is also one potential drawback, though. If somebody uses memory > hotplug for 1G (gigantic) hugetlb pages then this scheme will not work > for them obviously because each memory section will contain 2MB reserved > area. Actually I am wrong here. It is not each section in general. I have completely forgot that we do large memblocks on x86_64 with a lot of memory and then we hotadd 2GB memblocks and the altmap will allocate from the beginign of the _memblock_ and so all the memmaps will end up in the first memory section. -- Michal Hocko SUSE Labs