From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320AbdG2AGN (ORCPT ); Fri, 28 Jul 2017 20:06:13 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:33556 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752991AbdG2AGL (ORCPT ); Fri, 28 Jul 2017 20:06:11 -0400 Date: Fri, 28 Jul 2017 17:06:02 -0700 From: Greg Kroah-Hartman To: Arnd Bergmann Cc: devel@driverdev.osuosl.org, Michael Thayer , linux-kernel@vger.kernel.org, Hans de Goede , Daniel Vetter Subject: Re: [PATCH] staging: vboxvideo: select CONFIG_GENERIC_ALLOCATOR Message-ID: <20170729000602.GA5026@kroah.com> References: <20170728132118.261004-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170728132118.261004-1-arnd@arndb.de> User-Agent: Mutt/1.8.3 (2017-05-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 28, 2017 at 03:21:01PM +0200, Arnd Bergmann wrote: > vboxvideo fails to link without genalloc: > > drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_alloc': > vbox_hgsmi.c:(.text+0x1e): undefined reference to `gen_pool_dma_alloc' > drivers/staging/vboxvideo/vbox_hgsmi.o: In function `hgsmi_buffer_free': > vbox_hgsmi.c:(.text+0xf2): undefined reference to `gen_pool_free' > > This adds a Kconfig select statement, mirroring what all the other > users have. > > Fixes: dd55d44f4084 ("staging: vboxvideo: Add vboxvideo to drivers/staging") > Signed-off-by: Arnd Bergmann > --- > drivers/staging/vboxvideo/Kconfig | 1 + > 1 file changed, 1 insertion(+) Hans sent this same patch 2 days ago, sorry, just applied it now. greg k-h