From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753666AbdG2JSa (ORCPT ); Sat, 29 Jul 2017 05:18:30 -0400 Received: from Chamillionaire.breakpoint.cc ([146.0.238.67]:43906 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753188AbdG2JS2 (ORCPT ); Sat, 29 Jul 2017 05:18:28 -0400 Date: Sat, 29 Jul 2017 11:16:18 +0200 From: Florian Westphal To: Julia Lawall Cc: Florian Westphal , linux-decnet-user@lists.sourceforge.net, bhumirks@gmail.com, kernel-janitors@vger.kernel.org, Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] constify nf_hook_ops structures Message-ID: <20170729091618.GF28392@breakpoint.cc> References: <1501310455-7896-1-git-send-email-Julia.Lawall@lip6.fr> <20170729084429.GE28392@breakpoint.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Julia Lawall wrote: > > > On Sat, 29 Jul 2017, Florian Westphal wrote: > > > Julia Lawall wrote: > > > The nf_hook_ops structure is only passed as the second argument to > > > nf_register_net_hook or nf_unregister_net_hook, both of which are > > > declared as const. Thus the nf_hook_ops structure itself can be > > > const. > > > > Right, also see > > http://patchwork.ozlabs.org/patch/793767/ > > > > This series misses most of them (all arrays perhaps)? > > Yes, my rule doesn't look for arrays. I guess they are all done already > anyway? I think so (the patch is not yet applied though). >>From a quick glance I don't see why we can't e.g. constify nf_conntrack_l3/4_proto too. It is not going to be as simple as just placing const everywhere, but I see no requirement for having these writeable.