mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Marcus Wolf <marcus.wolf@wolf-entwicklungen.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, Colin King <colin.king@canonical.com>,
	kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static
Date: Sat, 29 Jul 2017 13:59:53 +0300	[thread overview]
Message-ID: <20170729105953.alvtnmjgw7g53cng@mwanda> (raw)
In-Reply-To: <1370919182.11119.1501319363782@ox.hosteurope.de>

On Sat, Jul 29, 2017 at 11:09:23AM +0200, Marcus Wolf wrote:
> Hi Greg,
>  
> also had a very close look to this patch. Even in your reply I can't find any
> problems with line wraps or other corruptions :-/
> 

Here are the relevant lines from Greg's email:

> +++ b/drivers/staging/pi433/rf69.c
> @@ -221,7 +221,7 @@ int rf69_set_frequency(struct spi_device *spi, u32
> frequency)

The "frequency)" bit is supposed to be on the line before.

regards,
dan carpenter

  reply	other threads:[~2017-07-29 11:00 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-18 13:03 [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static Colin King
2017-07-18 13:03 ` [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static Colin King
2017-07-19 19:52   ` Marcus Wolf
2017-07-20 11:01   ` [PATCH 1/1][staging-next] staging: pi433: Make functions rf69_set_dc_cut_off_frequency_intern static Wolf Entwicklungen
2017-07-20 12:58     ` Colin Ian King
2017-07-20 15:03       ` Marcus Wolf
2017-07-29  0:00     ` Greg Kroah-Hartman
2017-07-29  9:09       ` Marcus Wolf
2017-07-29 10:59         ` Dan Carpenter [this message]
2017-07-20 11:04   ` [PATCH 2/3][staging-next] staging: pi433: Make functions rf69_set_bandwidth_intern static Wolf Entwicklungen
2017-07-18 13:04 ` [PATCH 3/3][staging-next] staging: pi433: fix thread_run failure check Colin King
2017-07-20 11:02   ` Wolf Entwicklungen
2017-07-20 11:03 ` [PATCH 1/3][staging-next] staging: pi433: Make a couple of functions static Wolf Entwicklungen
2017-07-28 23:59 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170729105953.alvtnmjgw7g53cng@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=colin.king@canonical.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcus.wolf@wolf-entwicklungen.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®