mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Borislav Petkov <bp@suse.de>
To: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, tglx@linutronix.de,
	mingo@redhat.com, hpa@zytor.com
Subject: Re: [PATCH v2] x86/amd: Derive L3 shared_cpu_map from cpu_llc_shared_mask
Date: Sun, 30 Jul 2017 05:48:34 +0200	[thread overview]
Message-ID: <20170730034834.GA22240@nazgul.tnic> (raw)
In-Reply-To: <1501206755-2396-1-git-send-email-suravee.suthikulpanit@amd.com>

On Thu, Jul 27, 2017 at 08:52:35PM -0500, Suravee Suthikulpanit wrote:
> For system with X86_FEATURE_TOPOEXT, current logic use APIC ID to
> calculate shared_cpu_map. However, since APIC IDs are not guaranteed
> to be contiguous for cores across different L3 (e.g. family17h system
> w/ downcore configuration). This breaks the logic, and results in
> incorrect L3 shared_cpu_map.
> 
> Instead, always use the previously calculated cpu_llc_shared_mask of
> each cpu to derive L3 shared_cpu_map. This has been tested on
> family15h and family17h systems, which has L3 and support
> X86_FEATURE_TOPOEXT.
> 
> Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
> ---
>  arch/x86/kernel/cpu/intel_cacheinfo.c | 32 ++++++++++++++++++--------------
>  1 file changed, 18 insertions(+), 14 deletions(-)

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
-- 

      reply	other threads:[~2017-07-30  3:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28  1:52 Suravee Suthikulpanit
2017-07-30  3:48 ` Borislav Petkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170730034834.GA22240@nazgul.tnic \
    --to=bp@suse.de \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=suravee.suthikulpanit@amd.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®