From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753950AbdG3K6a (ORCPT ); Sun, 30 Jul 2017 06:58:30 -0400 Received: from mail-pf0-f196.google.com ([209.85.192.196]:35881 "EHLO mail-pf0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750988AbdG3K62 (ORCPT ); Sun, 30 Jul 2017 06:58:28 -0400 From: Axel Lin To: Lee Jones Cc: Keerthy , linux-kernel@vger.kernel.org, Axel Lin Subject: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Date: Sun, 30 Jul 2017 18:58:15 +0800 Message-Id: <20170730105815.26728-1-axel.lin@ingics.com> X-Mailer: git-send-email 2.9.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This fixes missing mfd_remove_devices() call when unload the module. Signed-off-by: Axel Lin --- drivers/mfd/lp87565.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c index 340ad0c..32d2a07 100644 --- a/drivers/mfd/lp87565.c +++ b/drivers/mfd/lp87565.c @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client, i2c_set_clientdata(client, lp87565); - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells, - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL); - - return ret; + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, + lp87565_cells, ARRAY_SIZE(lp87565_cells), + NULL, 0, NULL); } static const struct i2c_device_id lp87565_id_table[] = { -- 2.9.3