From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S932070AbdG3VHj (ORCPT <rfc822;w@1wt.eu>);
        Sun, 30 Jul 2017 17:07:39 -0400
Received: from isilmar-4.linta.de ([136.243.71.142]:60284 "EHLO
        isilmar-4.linta.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754236AbdG3VHi (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 30 Jul 2017 17:07:38 -0400
Date: Sun, 30 Jul 2017 23:06:38 +0200
From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Kees Cook <keescook@chromium.org>
Cc: Manfred Spraul <manfred@colorfullife.com>,
        LKML <linux-kernel@vger.kernel.org>
Subject: Re: lsipc(1) triggers general protection fault in
 sysvipc_shm_proc_show() on v4.13-rc2+
Message-ID: <20170730210638.GA1737@light.dominikbrodowski.net>
References: <20170730101042.GA1707@light.dominikbrodowski.net>
 <CAGXu5jLppEVGF7B+dC2VdLCWAuv-XodP0aygNeT=9u-3q+g2tQ@mail.gmail.com>
 <CAGXu5jKpua12WdS1ovhgGWS7T-Mdk2OSovteJGiw0JOe=xxSPA@mail.gmail.com>
 <20170730201641.GA28431@light.dominikbrodowski.net>
 <CAGXu5j+BoPVscCeMRxq6fyVdOVsnVmJvTHqgkW0x5C8D=32VRA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="fdj2RfSjLxBAspz7"
Content-Disposition: inline
In-Reply-To: <CAGXu5j+BoPVscCeMRxq6fyVdOVsnVmJvTHqgkW0x5C8D=32VRA@mail.gmail.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


--fdj2RfSjLxBAspz7
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sun, Jul 30, 2017 at 01:36:51PM -0700, Kees Cook wrote:
> On Sun, Jul 30, 2017 at 1:16 PM, Dominik Brodowski
> <linux@dominikbrodowski.net> wrote:
> > I've bisected it to between v4.13-rc1 and 96080f697786 so far, ~7 more
> > kernels/reboots to go. That leaves no code changes to ipc/, but some
> > randstruct changes ( I have set CONFIG_GCC_PLUGIN_RANDSTRUCT=3Dy ) which
> > touch some ipc-related code.
>=20
> Excellent, thanks; I bisected this as well. There was a missing
> container_of() in the proc handler. I've sent a patch for this now.
> Thanks for the report!

Thank you for fixing this issue - I can confirm that your patch (v2), on top
of v4.13-rc3, fixes the issue I've been seeing.

Thanks again,
	Dominik

--fdj2RfSjLxBAspz7
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEmgXaWKgmjrvkPhLCmpdgiUyNow0FAll+SlsACgkQmpdgiUyN
ow1KdhAAuJyLtJC5wS5VmlFVPr5GX90qmKhhsBCi9LhVO0UiUUfJJ1M314AxdD8u
uF7apuXneHj3YkyznwlfGzNmtzkOJ+FkWirukP/jfmnuQ/usPGO+BwKdxhJLPsC8
ioGQBfC0yKZftu05SU8yV/450QyrBqLbDxwrrfVi2rILQObGGm2Hlf1wneDs4mTQ
4Xezk8ODTIAgppy94QrtVvJNmq8IKRjeACdtK+zlmej9z9qBsP0A6d9nAHw5pewg
br8a5iCobsmSDFzdOjAzzUxSGqE8fkyGN7QDBp/1KqW+leK5sprzC/dvpIU/Lqe0
N570uHbzlQ2OmzTHAHesU+sLJFpHPV3gj59azUHdIoV1VLPLnt7kc9Xls4CygaeV
2CeQauGP6/X7sz7VB9ukynYSHoX5B91wPiB5dzJQOcgCMABsHtIx8XAJ3BND/g0H
bhxBt7OcarmPVohl9PN5J2JI7OLyPkW+XQZbpcZJE61CuiIu6MkQ/pK8TX/5P+Jg
0i5P9xqEr9131OHGbhfS/UCW6LfOPPybokDyzODlqqJ3DqYa/zb+zKdVTEnESjBW
z2bWx6qaNJjAdXyCdZzGkB4c+Qic7dt5aHQd9a8i5MBRA6WCJKD0URrf3Tph1N05
Ethf4OjZKke7UrIGPL+NHmf3GE65VNdwOGE7rNxM53Q+ogWd4bE=
=DMYh
-----END PGP SIGNATURE-----

--fdj2RfSjLxBAspz7--