From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752233AbdGaPQw (ORCPT ); Mon, 31 Jul 2017 11:16:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:60878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750987AbdGaPQv (ORCPT ); Mon, 31 Jul 2017 11:16:51 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A2BFC22B5D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Mon, 31 Jul 2017 11:16:48 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: jkosina@suse.cz, masami.hiramatsu.pt@hitachi.com, hpa@linux.intel.com, linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [RFC][PATCH]: x86: clarify/fix no-op barriers for text_poke_bp() Message-ID: <20170731111648.6c7d62f2@gandalf.local.home> In-Reply-To: <20170731150411.wff4c5qyanv7xtfy@hirez.programming.kicks-ass.net> References: <20170731102154.f57cvkjtnbmtctk6@hirez.programming.kicks-ass.net> <20170731102323.096376f5@gandalf.local.home> <20170731150411.wff4c5qyanv7xtfy@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 31 Jul 2017 17:04:11 +0200 Peter Zijlstra wrote: > Well, this is x86, its a NO-OP. The only reason to write barriers like Is it really a nop? > that is for documentation purposes and in that regard is confuses. IOW > has negative value. Not arguing. But a comment would have helped, even if it was /* This isn't really needed, but just being paranoid */ -- Steve