From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751775AbdHAW3t (ORCPT ); Tue, 1 Aug 2017 18:29:49 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:39202 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751648AbdHAW3p (ORCPT ); Tue, 1 Aug 2017 18:29:45 -0400 Date: Tue, 01 Aug 2017 15:29:43 -0700 (PDT) Message-Id: <20170801.152943.804666349488319640.davem@davemloft.net> To: keescook@chromium.org Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] drivers/net/wan/z85230.c: Use designated initializers From: David Miller In-Reply-To: <20170731013117.GA67801@beast> References: <20170731013117.GA67801@beast> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Aug 2017 15:29:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Sun, 30 Jul 2017 18:31:17 -0700 > In preparation for the randstruct gcc plugin performing randomization of > structures that are entirely function pointers, use designated initializers > so the compiler doesn't get angry. > > Reported-by: kbuild test robot > Signed-off-by: Kees Cook > --- > This is a prerequisite for the future randstruct fptr randomization. I'd > prefer to carry this in my gcc-plugin tree for v4.14 with an Ack from > someone on net-dev, or if possible, have it applied to v4.13 via net-dev. Please queue this up into the gcc-plugin tree then: Acked-by: David S. Miller It isn't a bug fix so I would only have put it into 'net-next' rather than 'net'. Thanks.