From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752004AbdHALDO (ORCPT ); Tue, 1 Aug 2017 07:03:14 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:43801 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751964AbdHALDN (ORCPT ); Tue, 1 Aug 2017 07:03:13 -0400 Date: Tue, 1 Aug 2017 14:02:01 +0300 From: Dan Carpenter To: Steven Rostedt , Sebastian Andrzej Siewior Cc: Ingo Molnar , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: [PATCH] tracing: missing error code in tracer_alloc_buffers() Message-ID: <20170801110201.ajdkct7vwzixahvx@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Mailer: git-send-email haha only kidding User-Agent: NeoMutt/20170609 (1.8.3) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If ring_buffer_alloc() or one of the next couple function calls fail then we should return -ENOMEM but the current code returns success. Fixes: b32614c03413 ('tracing/rb: Convert to hotplug state machine') Signed-off-by: Dan Carpenter diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c index 42b9355033d4..625c00aab800 100644 --- a/kernel/trace/trace.c +++ b/kernel/trace/trace.c @@ -8293,6 +8293,7 @@ __init static int tracer_alloc_buffers(void) if (ret < 0) goto out_free_cpumask; /* Used for event triggers */ + ret = -ENOMEM; temp_buffer = ring_buffer_alloc(PAGE_SIZE, RB_FL_OVERWRITE); if (!temp_buffer) goto out_rm_hp_state;