From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752092AbdHAMPY (ORCPT <rfc822;w@1wt.eu>);
        Tue, 1 Aug 2017 08:15:24 -0400
Received: from mx2.suse.de ([195.135.220.15]:53662 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751826AbdHAMPX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 1 Aug 2017 08:15:23 -0400
Date: Tue, 1 Aug 2017 14:15:20 +0200
From: Michal Hocko <mhocko@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Hugh Dickins <hughd@google.com>, Ingo Molnar <mingo@kernel.org>,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs, proc: remove unused variable
Message-ID: <20170801121519.GH15774@dhcp22.suse.cz>
References: <20170801152244.0a19eeb4@canb.auug.org.au>
 <20170801120150.1520051-1-arnd@arndb.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170801120150.1520051-1-arnd@arndb.de>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue 01-08-17 14:01:20, Arnd Bergmann wrote:
> The last cleanup can go a little further, as shown by this warning:
> 
> fs/proc/task_mmu.c: In function 'show_map_vma':
> fs/proc/task_mmu.c:285:28: error: unused variable 'priv' [-Werror=unused-variable]
> 
> Fixes: 14ccc3193225 ("fs, proc: remove priv argument from is_stack")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Thanks Arnd! Andrew, could you fold this into
fs-proc-remove-priv-argument-from-is_stack.patch please?

> ---
>  fs/proc/task_mmu.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 9782dedeead7..186e907187ab 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -282,7 +282,6 @@ show_map_vma(struct seq_file *m, struct vm_area_struct *vma, int is_pid)
>  {
>  	struct mm_struct *mm = vma->vm_mm;
>  	struct file *file = vma->vm_file;
> -	struct proc_maps_private *priv = m->private;
>  	vm_flags_t flags = vma->vm_flags;
>  	unsigned long ino = 0;
>  	unsigned long long pgoff = 0;
> -- 
> 2.9.0
> 

-- 
Michal Hocko
SUSE Labs