From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751931AbdHAMSA (ORCPT ); Tue, 1 Aug 2017 08:18:00 -0400 Received: from mx2.suse.de ([195.135.220.15]:53941 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751680AbdHAMR7 (ORCPT ); Tue, 1 Aug 2017 08:17:59 -0400 Date: Tue, 1 Aug 2017 14:17:55 +0200 From: Michal Hocko To: Jerome Glisse Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, John Hubbard , Dan Williams , David Nellans , Evgeny Baskakov , Mark Hairgrove , Sherry Cheung , Subhash Gutti Subject: Re: [PATCH 09/15] mm/hmm/devmem: device memory hotplug using ZONE_DEVICE v6 Message-ID: <20170801121755.GJ15774@dhcp22.suse.cz> References: <20170628180047.5386-1-jglisse@redhat.com> <20170628180047.5386-10-jglisse@redhat.com> <20170728111003.GA2278@dhcp22.suse.cz> <20170731172122.GA24626@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170731172122.GA24626@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon 31-07-17 13:21:24, Jerome Glisse wrote: > On Fri, Jul 28, 2017 at 01:10:03PM +0200, Michal Hocko wrote: > > I haven't seen a newer version posted but the same comment applies on > > your hmm-v25-4.9 git version from > > git://people.freedesktop.org/~glisse/linux > > > > On Wed 28-06-17 14:00:41, Jérôme Glisse wrote: > > > This introduce a simple struct and associated helpers for device driver > > > to use when hotpluging un-addressable device memory as ZONE_DEVICE. It > > > will find a unuse physical address range and trigger memory hotplug for > > > it which allocates and initialize struct page for the device memory. > > > > Please document the hotplug semantic some more please (who is in charge, > > what is the lifetime, userspace API to add/remove this memory if any > > etc...). > > > > I can see you call add_pages. Please document why arch_add_memory (like > > devm_memremap_pages) is not used. You also never seem to online the > > range which is in line with nvdim usage and it is OK. But then I fail to > > understand why you need > > I added documentation in function and in commit message: > https://cgit.freedesktop.org/~glisse/linux/commit/?h=hmm-next&id=33e236a64da84423c83db401fc62ea13877111f2 OK, that makes more clear. Thanks! -- Michal Hocko SUSE Labs