mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: kan.liang@intel.com
Cc: linux-kernel@vger.kernel.org, axboe@fb.com,
	viro@zeniv.linux.org.uk, kirill.shutemov@linux.intel.com,
	ying.huang@intel.com, npiggin@gmail.com, mingo@kernel.org
Subject: Re: [PATCH] mm: allow page_cache_get_speculative in interrupt context
Date: Tue, 1 Aug 2017 12:49:18 -0700	[thread overview]
Message-ID: <20170801124918.af266c95fa6671e6cc1dc136@linux-foundation.org> (raw)
In-Reply-To: <1501609146-59730-1-git-send-email-kan.liang@intel.com>

On Tue,  1 Aug 2017 13:39:06 -0400 kan.liang@intel.com wrote:

> Kernel panic when calling the IRQ-safe __get_user_pages_fast in NMI
> handler.
> 
> The bug was introduced by commit:
> 
>   2947ba054a4d ("x86/mm/gup: Switch GUP to the generic
> get_user_page_fast() implementation")
> 
> The original x86 __get_user_page_fast used plain get_page() or
> page_ref_add(). However, the generic __get_user_page_fast uses
> page_cache_get_speculative(), which has VM_BUG_ON(in_interrupt()).
> 
> There is no reason to prevent page_cache_get_speculative from using in
> interrupt context. According to the author, putting a BUG_ON there is
> just because the code is not verifying correctness of interrupt races.
> I did some tests in interrupt context. There is no issue found.
> Removing VM_BUG_ON(in_interrupt()) for page_cache_get_speculative().

What code calls page_cache_get_speculative() from NMI context?  

I'm trying to work out which kernel versions need this fix, but there
isn't enough info in the changelog for this.  Please don't do that.

  reply	other threads:[~2017-08-01 19:49 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 17:39 kan.liang
2017-08-01 19:49 ` Andrew Morton [this message]
2017-08-01 20:31   ` Liang, Kan
2017-08-01 20:51     ` Kirill A. Shutemov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801124918.af266c95fa6671e6cc1dc136@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=axboe@fb.com \
    --cc=kan.liang@intel.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=npiggin@gmail.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=ying.huang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®