mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Egil Hjelmeland <privat@egil-hjelmeland.no>
Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing()
Date: Tue, 1 Aug 2017 15:39:34 +0200	[thread overview]
Message-ID: <20170801133934.GB23157@lunn.ch> (raw)
In-Reply-To: <20170801111439.1143-2-privat@egil-hjelmeland.no>

> @@ -704,7 +710,7 @@ static void lan9303_get_ethtool_stats(struct dsa_switch *ds, int port,
>  	unsigned int u, poff;
>  	int ret;
>  
> -	poff = port * 0x400;
> +	poff = LAN9303_SWITCH_PORT_REG(port, 0);
>  
>  	for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
>  		ret = lan9303_read_switch_reg(chip,

So the actual code is:

	for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
       		ret = lan9303_read_switch_reg(chip,
			      		      lan9303_mib[u].offset + poff,
					      &reg);

Could this be written as

	for (u = 0; u < ARRAY_SIZE(lan9303_mib); u++) {
		ret = lan9303_read_switch_port(chip, port, lan9303_mib[u].offset, &reg);

It is then clear you are reading the statistics from a port register.

   Andrew

  reply	other threads:[~2017-08-01 13:40 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 11:14 [PATCH v2 net-next 0/3] Refactor lan9303_xxx_packet_processing Egil Hjelmeland
2017-08-01 11:14 ` [PATCH v2 net-next 1/3] net: dsa: lan9303: Refactor lan9303_xxx_packet_processing() Egil Hjelmeland
2017-08-01 13:39   ` Andrew Lunn [this message]
2017-08-01 13:50     ` Egil Hjelmeland
2017-08-01 14:02       ` Andrew Lunn
2017-08-01 14:43         ` Egil Hjelmeland
2017-08-01 11:14 ` [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 Egil Hjelmeland
2017-08-01 11:49   ` Juergen Borleis
2017-08-01 12:31     ` Egil Hjelmeland
2017-08-01 13:27       ` Andrew Lunn
2017-08-01 13:45         ` Egil Hjelmeland
2017-08-03  9:53         ` Egil Hjelmeland
2017-08-03 13:33           ` Andrew Lunn
2017-08-01 11:14 ` [PATCH v2 net-next 3/3] net: dsa: lan9303: Simplify lan9303_xxx_packet_processing() usage Egil Hjelmeland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170801133934.GB23157@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=f.fainelli@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=privat@egil-hjelmeland.no \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®