From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbdHALuA convert rfc822-to-8bit (ORCPT ); Tue, 1 Aug 2017 07:50:00 -0400 Received: from metis.ext.4.pengutronix.de ([92.198.50.35]:41039 "EHLO metis.ext.4.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751595AbdHALt6 (ORCPT ); Tue, 1 Aug 2017 07:49:58 -0400 From: Juergen Borleis Organization: Pengutronix e.K. To: kernel@pengutronix.de Subject: Re: [PATCH v2 net-next 2/3] net: dsa: lan9303: define LAN9303_NUM_PORTS 3 Date: Tue, 1 Aug 2017 13:49:51 +0200 User-Agent: KMail/1.9.10 (enterprise35 0.20100827.1168748) Cc: Egil Hjelmeland , andrew@lunn.ch, vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170801111439.1143-1-privat@egil-hjelmeland.no> <20170801111439.1143-3-privat@egil-hjelmeland.no> In-Reply-To: <20170801111439.1143-3-privat@egil-hjelmeland.no> X-KMail-QuotePrefix: > MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <201708011349.52529.jbe@pengutronix.de> X-SA-Exim-Connect-IP: 2001:67c:670:100:2e4d:54ff:fe67:bfa5 X-SA-Exim-Mail-From: jbe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Egil, On Tuesday 01 August 2017 13:14:38 Egil Hjelmeland wrote: > Will be used instead of '3' in upcomming patches. > > Signed-off-by: Egil Hjelmeland > --- > drivers/net/dsa/lan9303-core.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/dsa/lan9303-core.c > b/drivers/net/dsa/lan9303-core.c index 4c514d3b9f68..2a3c6bf473dd 100644 > --- a/drivers/net/dsa/lan9303-core.c > +++ b/drivers/net/dsa/lan9303-core.c > @@ -20,6 +20,8 @@ > > #include "lan9303.h" > > +#define LAN9303_NUM_PORTS 3 > + > /* 13.2 System Control and Status Registers > * Multiply register number by 4 to get address offset. > */ Maybe we should put this macro into a shared location because in "net/dsa/tag_lan9303.c" there is already a "#define LAN9303_MAX_PORTS 3". jb -- Pengutronix e.K.                             | Juergen Borleis             | Industrial Linux Solutions                   | http://www.pengutronix.de/  |