From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdHBRmr (ORCPT ); Wed, 2 Aug 2017 13:42:47 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54960 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751696AbdHBRmq (ORCPT ); Wed, 2 Aug 2017 13:42:46 -0400 Date: Wed, 02 Aug 2017 10:42:45 -0700 (PDT) Message-Id: <20170802.104245.634918252454302878.davem@davemloft.net> To: arnd@arndb.de Cc: f.fainelli@gmail.com, michael.chan@broadcom.com, sathya.perla@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] net: bcmgenet: drop COMPILE_TEST dependency From: David Miller In-Reply-To: <20170801115121.1246540-1-arnd@arndb.de> References: <20170801115121.1246540-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 02 Aug 2017 10:42:46 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Tue, 1 Aug 2017 13:50:56 +0200 > The last patch added the dependency on 'OF && HAS_IOMEM' but left > COMPILE_TEST as an alternative, which kind of defeats the purpose > of adding the dependency, we still get randconfig build warnings: > > warning: (NET_DSA_BCM_SF2 && BCMGENET) selects MDIO_BCM_UNIMAC which has unmet direct dependencies (NETDEVICES && MDIO_BUS && HAS_IOMEM && OF_MDIO) > > For compile-testing purposes, we don't really need this anyway, > as CONFIG_OF can be enabled on all architectures, and HAS_IOMEM > is present on all architectures we do meaningful compile-testing on > (the exception being arch/um). > > This makes both OF and HAS_IOMEM hard dependencies. > > Fixes: 5af74bb4fcf8 ("net: bcmgenet: Add dependency on HAS_IOMEM && OF") > Signed-off-by: Arnd Bergmann Applied.