From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751916AbdHBDXp (ORCPT ); Tue, 1 Aug 2017 23:23:45 -0400 Received: from mail-pg0-f45.google.com ([74.125.83.45]:36897 "EHLO mail-pg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdHBDXn (ORCPT ); Tue, 1 Aug 2017 23:23:43 -0400 Date: Wed, 2 Aug 2017 08:53:37 +0530 From: Viresh Kumar To: Leonard Crestez Cc: Rafael Wysocki , Shawn Guo , Sascha Hauer , Fabio Estevam , linux-pm@vger.kernel.org, Vincent Guittot , linux@dominikbrodowski.net, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3 3/9] cpufreq: Cap the default transition delay value to 10 ms Message-ID: <20170802032337.GA26689@vireshk-i7> References: <1b93c94cb8b4914314e4f50304c3cb11c53d8b14.1500373914.git.viresh.kumar@linaro.org> <1500983686.30745.28.camel@nxp.com> <20170726060634.GY352@vireshk-i7> <1501174453.7957.30.camel@nxp.com> <20170728052843.GT352@vireshk-i7> <1501609730.17254.5.camel@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1501609730.17254.5.camel@nxp.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01-08-17, 20:48, Leonard Crestez wrote: > > > I found this by enabling the power:cpu_frequency tracepoint event and > > > checking for deltas with a script. Enabling CPU_FREQ_STAT show this: > > > > > > time_in_state: > > > > > > 396000 1609 > > So we still stay at the lowest frequency most of the time. > > Yes Aren't these numbers you shared were taken after this patch is applied? What's wrong with the numbers then ? > > Maybe can you compare these values with and without this patch to let > > us know? > > Without the patch it is always at low freq. Sampling at a lower > frequency means spikes get ignored. -- viresh