mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Wolf Entwicklungen <Marcus.Wolf@Wolf-Entwicklungen.de>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
	Rishabh Hardas <rishabhhardas@gmail.com>,
	gregkh@linuxfoundation.org
Subject: Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it.
Date: Wed, 2 Aug 2017 12:33:07 +0300	[thread overview]
Message-ID: <20170802093307.ngy6243hnv4nuynm@mwanda> (raw)
In-Reply-To: <29d720045e6b843c9bf6e39d5c5e49eb-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXMCVFM=-webmailer1@server03.webmailer.webmailer.hosteurope.de>

On Wed, Aug 02, 2017 at 11:15:16AM +0200, Wolf Entwicklungen wrote:
> Hi Dan,
> 
> I offered Greg to have an eye on the patches, that were submitted. He asked
> me to reply to those patches, I had a look for, with the Reviewed-by tag.
> 
> Now I am a bit unsure, what I should do.
> 
> Since I am interested in, I for sure will read every patch. It's just a little
> thing, to reply with reviewed-tag - if you / Greg like(s). I can do so on every
> reviewed patch, only on patches without need/wish of improvement or never.
> 
> Compiling every patch is a bit inconvenient.
> 
> Please let me know, what you and Greg would like.

That's fine, you don't need to build test them if you don't want to.
Greg is going to do it.

But in this case, it was pretty obvious that it was going to break git
bisect right?  That's not allowed.  You're not expected to know all the
rules when you start so that's fine.  I'm just trying to give you some
ideas what to look for in the future.

regards,
dan carpenter

  reply	other threads:[~2017-08-02  9:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-01 19:31 Rishabh Hardas
2017-08-01 19:31 ` [PATCH 2/5] staging/pi433/pi433_if.c:Removed " Rishabh Hardas
2017-08-02  8:09   ` Wolf Entwicklungen
2017-08-02  8:26   ` Dan Carpenter
2017-08-01 19:31 ` [PATCH 3/5] staging/pi433/rf69.h:Removed " Rishabh Hardas
2017-08-02  8:10   ` Wolf Entwicklungen
2017-08-01 19:31 ` [PATCH 4/5] staging/pi433/rf69.c:Removed " Rishabh Hardas
2017-08-02  8:13   ` Wolf Entwicklungen
2017-08-01 19:31 ` [PATCH 5/5] staging/pi433/rf69_enum.h:Removed " Rishabh Hardas
2017-08-02  8:14   ` Wolf Entwicklungen
2017-08-02  8:08 ` [PATCH 1/5] staging/pi433:Removed " Wolf Entwicklungen
2017-08-02  8:34   ` Dan Carpenter
2017-08-02  8:52     ` Marcus Wolf
2017-08-02  8:59       ` Dan Carpenter
2017-08-02  9:15         ` Wolf Entwicklungen
2017-08-02  9:33           ` Dan Carpenter [this message]
     [not found]             ` <CAOo1wfVa6HoRLK9nXmnGotQ9n_hVmB01Osm1XjgJf3J_vqrY_g@mail.gmail.com>
2017-08-02 10:51               ` Dan Carpenter
2017-08-02  8:19 ` Dan Carpenter
2017-08-02  8:23 ` Dan Carpenter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802093307.ngy6243hnv4nuynm@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=Marcus.Wolf@Wolf-Entwicklungen.de \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rishabhhardas@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®