mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: riel@redhat.com
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
	mingo@kernel.org, jhladky@redhat.com, lvenanci@redhat.com
Subject: Re: [RHEL-ALT-7.4 PATCH 2/2] sched,numa: scale scan period with tasks in group and shared/private
Date: Wed, 2 Aug 2017 11:22:55 +0100	[thread overview]
Message-ID: <20170802102255.4tc7jpyt52kjj7tq@suse.de> (raw)
In-Reply-To: <20170731192847.23050-3-riel@redhat.com>

On Mon, Jul 31, 2017 at 03:28:47PM -0400, Rik van Riel wrote:
> From: Rik van Riel <riel@redhat.com>
> 
> Running 80 tasks in the same group, or as threads of the same process,
> results in the memory getting scanned 80x as fast as it would be if a
> single task was using the memory.
> 
> This really hurts some workloads.
> 

It would be nice to specify what workloads in particular and what sort
of machine because I'm willing to bet it has a bigger impact on machines
with 4+ nodes, particularly if they are not fully connected topologies.
Furthermore, I'm willing to bet that there would be small regressions on
2-socket machines but with less time spent scanning and processing
faults even if remote accesses are marginally increased.

Still, on balance, this is preferred behaviour.

> Scale the scan period by the number of tasks in the numa group, and
> the shared / private ratio, so the average rate at which memory in
> the group is scanned corresponds roughly to the rate at which a single
> task would scan its memory.
> 
> Signed-off-by: Rik van Riel <riel@redhat.com>

Acked-by: Mel Gorman <mgorman@suse.de>

-- 
Mel Gorman
SUSE Labs

  reply	other threads:[~2017-08-02 10:22 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-31 19:28 [PATCH 0/2] numa,sched: improve performance for multi-threaded workloads riel
2017-07-31 19:28 ` [RHEL-ALT-7.4 PATCH 1/2] numa,sched: slow down scan rate if shared faults dominate riel
2017-08-02  7:01   ` Mel Gorman
2017-08-10 12:07   ` [tip:sched/core] sched/numa: Slow " tip-bot for Rik van Riel
2017-07-31 19:28 ` [RHEL-ALT-7.4 PATCH 2/2] sched,numa: scale scan period with tasks in group and shared/private riel
2017-08-02 10:22   ` Mel Gorman [this message]
2017-08-10 12:07   ` [tip:sched/core] sched/numa: Scale " tip-bot for Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170802102255.4tc7jpyt52kjj7tq@suse.de \
    --to=mgorman@suse.de \
    --cc=jhladky@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lvenanci@redhat.com \
    --cc=mingo@kernel.org \
    --cc=peterz@infradead.org \
    --cc=riel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome