From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752285AbdHBSoX (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Aug 2017 14:44:23 -0400
Received: from mail-qk0-f171.google.com ([209.85.220.171]:36730 "EHLO
        mail-qk0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751197AbdHBSoV (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Aug 2017 14:44:21 -0400
Date: Wed, 2 Aug 2017 11:44:17 -0700
From: Tejun Heo <tj@kernel.org>
To: Roman Gushchin <guro@fb.com>
Cc: cgroups@vger.kernel.org, Zefan Li <lizefan@huawei.com>,
        Waiman Long <longman@redhat.com>, Johannes Weiner <hannes@cmpxchg.org>,
        kernel-team@fb.com, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [RFC 2/4] cgroup: implement hierarchy limits
Message-ID: <20170802184416.GK2311718@devbig577.frc2.facebook.com>
References: <20170802165532.22277-1-guro@fb.com>
 <20170802165532.22277-3-guro@fb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170802165532.22277-3-guro@fb.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello, Roman.

Generally looks good to me.  One minor nit.

On Wed, Aug 02, 2017 at 05:55:30PM +0100, Roman Gushchin wrote:
> +static ssize_t cgroup_max_descendants_write(struct kernfs_open_file *of,
> +					   char *buf, size_t nbytes, loff_t off)
> +{
> +	struct cgroup *cgrp;
> +	int descendants;
> +	ssize_t ret;
> +
> +	buf = strstrip(buf);
> +	if (!strcmp(buf, "max")) {
> +		descendants = INT_MAX;
> +	} else {
> +		ret = kstrtouint(buf, 0, &descendants);
                     ^^^^^^^^^^^
		     shouldn't this be kstrtoint?

Thanks.

-- 
tejun