From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbdHBSu3 (ORCPT ); Wed, 2 Aug 2017 14:50:29 -0400 Received: from mail-qt0-f170.google.com ([209.85.216.170]:33848 "EHLO mail-qt0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752398AbdHBSu1 (ORCPT ); Wed, 2 Aug 2017 14:50:27 -0400 Date: Wed, 2 Aug 2017 11:50:24 -0700 From: Tejun Heo To: Roman Gushchin Cc: cgroups@vger.kernel.org, Zefan Li , Waiman Long , Johannes Weiner , kernel-team@fb.com, linux-kernel@vger.kernel.org Subject: Re: [RFC 4/4] cgroup: re-use the parent pointer in cgroup_destroy_locked() Message-ID: <20170802185023.GL2311718@devbig577.frc2.facebook.com> References: <20170802165532.22277-1-guro@fb.com> <20170802165532.22277-5-guro@fb.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170802165532.22277-5-guro@fb.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 02, 2017 at 05:55:32PM +0100, Roman Gushchin wrote: > As we already have a pointer to the parent cgroup in > cgroup_destroy_locked(), we don't need to calculate it again > to pass as an argument for cgroup1_check_for_release(). Except for the minor nit earlier, everything in the series looks good to me. Thanks. -- tejun