From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752685AbdHBUAg (ORCPT ); Wed, 2 Aug 2017 16:00:36 -0400 Received: from mail.kernel.org ([198.145.29.99]:60972 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752397AbdHBUAe (ORCPT ); Wed, 2 Aug 2017 16:00:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9507922BD4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=helgaas@kernel.org Date: Wed, 2 Aug 2017 15:00:31 -0500 From: Bjorn Helgaas To: Palmer Dabbelt Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, bhelgaas@google.com, hch@infradead.org, Arnd Bergmann , linux-snps-arc@lists.infradead.org, linux-cris-kernel@axis.com, linux-ia64@vger.kernel.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org Subject: Re: pci: Add generic pcibios_{fixup_bus,align_resource} Message-ID: <20170802200031.GD20308@bhelgaas-glaptop.roam.corp.google.com> References: <20170624015044.16746-1-palmer@dabbelt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170624015044.16746-1-palmer@dabbelt.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 23, 2017 at 06:50:41PM -0700, Palmer Dabbelt wrote: > While upstreaming the RISC-V port, it was pointed out that multiple > architectures have copied the mostly empty versions of at least one of these > functions. This defines weakly bound versions of the common functions and > removes the now obselete functions from other ports. > > This has been split out from the RISC-V submission so we can decouple all these > generic changes from our port review process. There's some discussion on an > earlier version of the patch here > > https://lkml.org/lkml/2017/6/6/998 > > but I'm afraid a lot of this is really out of my wheelhouse (and I'm pretty > slammed trying to get the RISC-V port in better shape), so I'm afraid I'm not > going to be able to perform the full cleanup suggested. Applied to pci/resource for v4.14, thanks! There's room for future improvement, e.g., using per-host callbacks, etc., but I think this is a clear improvement as-is. There's some folklore about the evils of weak symbols, but I don't know the details. It would be useful to have them codified somewhere in Documentation/ or near the __weak definition.