From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751237AbdHCH2M (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Aug 2017 03:28:12 -0400
Received: from mx2.suse.de ([195.135.220.15]:54266 "EHLO mx1.suse.de"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1751062AbdHCH2L (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Aug 2017 03:28:11 -0400
Date: Thu, 3 Aug 2017 09:27:57 +0200
From: Jean Delvare <jdelvare@suse.de>
To: Bhumika Goyal <bhumirks@gmail.com>
Cc: julia.lawall@lip6.fr, arnd@arndb.de, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] MISC: add const to bin_attribute structures
Message-ID: <20170803092757.63780050@endymion>
In-Reply-To: <1501665006-20451-1-git-send-email-bhumirks@gmail.com>
References: <1501665006-20451-1-git-send-email-bhumirks@gmail.com>
Organization: SUSE Linux
X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.31; x86_64-suse-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed,  2 Aug 2017 14:40:06 +0530, Bhumika Goyal wrote:
> Add const to bin_attribute structures as they are only passed to the
> functions sysfs_{remove/create}_bin_file. The arguments passed are of
> type const, so declare the structures to be const.
> 
> Done using Coccinelle.
> 
> @m disable optional_qualifier@
> identifier s;
> position p;
> @@
> static struct bin_attribute s@p={...};
> 
> @okay1@
> position p;
> identifier m.s;
> @@
> (
> sysfs_create_bin_file(...,&s@p,...)
> |
> sysfs_remove_bin_file(...,&s@p,...)
> )
> 
> @bad@
> position p!={m.p,okay1.p};
> identifier m.s;
> @@
> s@p
> 
> @change depends on !bad disable optional_qualifier@
> identifier m.s;
> @@
> static
> +const
> struct bin_attribute s={...};
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
> ---
>  drivers/misc/ds1682.c         | 2 +-
>  drivers/misc/eeprom/eeprom.c  | 2 +-
>  drivers/misc/eeprom/max6875.c | 2 +-
>  drivers/misc/pch_phub.c       | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> (...)

Reviewed-by: Jean Delvare <jdelvare@suse.de>

Thanks,
-- 
Jean Delvare
SUSE L3 Support