mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Cihangir Akturk <cakturk@gmail.com>
Cc: David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 05/29] drm/atmel-hlcdc: switch to drm_*{get,put} helpers
Date: Thu, 3 Aug 2017 16:55:39 +0200	[thread overview]
Message-ID: <20170803165539.647ecb05@bbrezillon> (raw)
In-Reply-To: <20170803141050.16e78d78@bbrezillon>

On Thu, 3 Aug 2017 14:10:50 +0200
Boris Brezillon <boris.brezillon@free-electrons.com> wrote:

> On Thu,  3 Aug 2017 14:58:20 +0300
> Cihangir Akturk <cakturk@gmail.com> wrote:
> 
> > drm_*_reference() and drm_*_unreference() functions are just
> > compatibility alias for drm_*_get() and drm_*_put() adn should not be  
> 
> s/adn/and/
> 
> > used by new code. So convert all users of compatibility functions to use
> > the new APIs.
> > 
> > Signed-off-by: Cihangir Akturk <cakturk@gmail.com>  
> 
> Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Applied to drm-misc-next (as suggested by Daniel) after fixing the
typo.

Thanks,

Boris

> 
> > ---
> >  drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > index 1124200..fc3f910 100644
> > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c
> > @@ -809,7 +809,7 @@ static void atmel_hlcdc_plane_destroy(struct drm_plane *p)
> >  	struct atmel_hlcdc_plane *plane = drm_plane_to_atmel_hlcdc_plane(p);
> >  
> >  	if (plane->base.fb)
> > -		drm_framebuffer_unreference(plane->base.fb);
> > +		drm_framebuffer_put(plane->base.fb);
> >  
> >  	drm_plane_cleanup(p);
> >  }
> > @@ -958,7 +958,7 @@ static void atmel_hlcdc_plane_reset(struct drm_plane *p)
> >  		state = drm_plane_state_to_atmel_hlcdc_plane_state(p->state);
> >  
> >  		if (state->base.fb)
> > -			drm_framebuffer_unreference(state->base.fb);
> > +			drm_framebuffer_put(state->base.fb);
> >  
> >  		kfree(state);
> >  		p->state = NULL;
> > @@ -996,7 +996,7 @@ atmel_hlcdc_plane_atomic_duplicate_state(struct drm_plane *p)
> >  	}
> >  
> >  	if (copy->base.fb)
> > -		drm_framebuffer_reference(copy->base.fb);
> > +		drm_framebuffer_get(copy->base.fb);
> >  
> >  	return &copy->base;
> >  }
> > @@ -1015,7 +1015,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p,
> >  	}
> >  
> >  	if (s->fb)
> > -		drm_framebuffer_unreference(s->fb);
> > +		drm_framebuffer_put(s->fb);
> >  
> >  	kfree(state);
> >  }  
> 

  reply	other threads:[~2017-08-03 14:55 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1501761585-11757-1-git-send-email-cakturk@gmail.com>
2017-08-03 11:58 ` [PATCH 01/29] drm/amdgpu: " Cihangir Akturk
2017-08-03 12:08   ` Christian König
2017-08-03 11:58 ` [PATCH 02/29] drm: mali-dp: " Cihangir Akturk
2017-08-03 14:02   ` Liviu Dudau
2017-08-03 11:58 ` [PATCH 03/29] drm/armada: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 04/29] drm/ast: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 05/29] drm/atmel-hlcdc: " Cihangir Akturk
2017-08-03 12:10   ` Boris Brezillon
2017-08-03 14:55     ` Boris Brezillon [this message]
2017-08-03 11:58 ` [PATCH 06/29] drm/bochs: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 07/29] drm/cirrus: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 08/29] drm/etnaviv: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 09/29] drm/exynos: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 10/29] drm/gma500: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 11/29] drm/hisilicon: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 12/29] drm/i915: " Cihangir Akturk
2017-08-03 12:26   ` Jani Nikula
2017-08-03 12:49     ` Daniel Vetter
2017-08-03 15:52       ` Cihangir Akturk
2017-08-07  9:10         ` Daniel Vetter
2017-08-03 15:36     ` Cihangir Akturk
2017-08-04  8:18       ` Jani Nikula
2017-08-03 11:58 ` [PATCH 13/29] drm/imx: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 14/29] drm/mediatek: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 15/29] drm/mgag200: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 16/29] drm/msm: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 17/29] drm/nouveau: " Cihangir Akturk
2017-08-03 13:05   ` Tobias Klausmann
2017-08-03 11:58 ` [PATCH 18/29] drm/omap: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 19/29] drm/qxl: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 20/29] drm/radeon: " Cihangir Akturk
2017-08-03 12:08   ` Christian König
2017-08-03 16:27     ` Alex Deucher
2017-08-03 11:58 ` [PATCH 21/29] drm/rockchip: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 22/29] drm/tegra: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 23/29] drm/tilcdc: " Cihangir Akturk
2017-08-03 13:56   ` Jyri Sarha
2017-08-03 15:42     ` Daniel Vetter
2017-08-03 17:37       ` Jyri Sarha
2017-08-03 11:58 ` [PATCH 24/29] drm/udl: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 25/29] drm/vc4: " Cihangir Akturk
2017-08-08 20:39   ` Eric Anholt
2017-08-03 11:58 ` [PATCH 26/29] drm/vgem: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 27/29] drm/virtio: " Cihangir Akturk
2017-08-03 11:58 ` [PATCH 28/29] drm/vmwgfx: " Cihangir Akturk
2017-08-03 12:40   ` Thomas Hellstrom
2017-08-03 13:06     ` Daniel Vetter
2017-08-03 11:58 ` [PATCH 29/29] staging: vboxvideo: " Cihangir Akturk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170803165539.647ecb05@bbrezillon \
    --to=boris.brezillon@free-electrons.com \
    --cc=airlied@linux.ie \
    --cc=cakturk@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome