From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752052AbdHDSa4 (ORCPT ); Fri, 4 Aug 2017 14:30:56 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:37604 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751324AbdHDSaz (ORCPT ); Fri, 4 Aug 2017 14:30:55 -0400 Date: Fri, 04 Aug 2017 11:30:54 -0700 (PDT) Message-Id: <20170804.113054.760644132949601023.davem@davemloft.net> To: tsbogend@alpha.franken.de Cc: isubramanian@apm.com, kchudgar@apm.com, qnguyen@apm.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, labbott@redhat.com Subject: Re: [PATCH net] xgene: Always get clk source, but ignore if it's missing for SGMII ports From: David Miller In-Reply-To: <20170803140311.34C7E50870B@solo.franken.de> References: <20170803140311.34C7E50870B@solo.franken.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 04 Aug 2017 11:30:55 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Thomas Bogendoerfer Date: Thu, 3 Aug 2017 15:43:14 +0200 > From: Thomas Bogendoerfer > > Even the driver doesn't do anything with the clk source for SGMII > ports it needs to be enabled by doing a devm_clk_get(), if there is > a clk source in DT. > > Fixes: 0db01097cabd ('xgene: Don't fail probe, if there is no clk resource for SGMII interfaces') > Signed-off-by: Thomas Bogendoerfer > Tested-by: Laura Abbott > Acked-by: Iyappan Subramanian Applied, thanks.