From: Peter Zijlstra <peterz@infradead.org>
To: Cheng Jian <cj.chengjian@huawei.com>
Cc: mingo@redhat.com, akpm@linux-foundation.org,
linux-kernel@vger.kernel.org, xiexiuqi@huawei.com,
huawei.libin@huawei.com
Subject: Re: [PATCH] sched/core: Remove unnecessary initialization init_idle_bootup_task()
Date: Fri, 4 Aug 2017 11:43:23 +0200 [thread overview]
Message-ID: <20170804094323.itq4lcjtf7puxyms@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <1501838377-109720-1-git-send-email-cj.chengjian@huawei.com>
On Fri, Aug 04, 2017 at 05:19:37PM +0800, Cheng Jian wrote:
> init_idle_bootup_task( ) is called in rest_init( ) to switch
> the scheduling class of the boot thread to the idle class
>
> the function only set :
> idle->sched_class = &idle_sched_class;
> which has been set in init_idle() called by sched_init()
> /*
> * The idle tasks have their own, simple scheduling class:
> */
> idle->sched_class = &idle_sched_class;
>
> We've already set the boot thread to idle class in
> start_kernel()->sched_init()->init_idle()
> so it's unnecessary to set it again in
> start_kernel()->rest_init()->init_idle_bootup_task()
Yeah, does look a bit redundant. Thanks!
next prev parent reply other threads:[~2017-08-04 9:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-04 9:19 Cheng Jian
2017-08-04 9:43 ` Peter Zijlstra [this message]
2017-08-10 12:09 ` [tip:sched/core] " tip-bot for Cheng Jian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170804094323.itq4lcjtf7puxyms@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=cj.chengjian@huawei.com \
--cc=huawei.libin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=xiexiuqi@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®