From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbdHDKMI (ORCPT ); Fri, 4 Aug 2017 06:12:08 -0400 Received: from mga02.intel.com ([134.134.136.20]:34739 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751285AbdHDKMG (ORCPT ); Fri, 4 Aug 2017 06:12:06 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,320,1498546800"; d="scan'208";a="1159122078" Date: Fri, 4 Aug 2017 13:12:02 +0300 From: Mika Westerberg To: Masahiro Yamada Cc: linux-gpio@vger.kernel.org, Andy Shevchenko , Linus Walleij , linux-kernel@vger.kernel.org Subject: Re: [PATCH] pinctrl: check ops->pin_config_set in pinconf_set_config() Message-ID: <20170804101202.GW2369@lahna.fi.intel.com> References: <1501815572-2792-1-git-send-email-yamada.masahiro@socionext.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501815572-2792-1-git-send-email-yamada.masahiro@socionext.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 04, 2017 at 11:59:32AM +0900, Masahiro Yamada wrote: > pinconf_set_config() is called by pinctrl_gpio_set_config(). > If a GPIO driver is backed by a pinctrl driver and it does not > support .pin_config_set() hook, it causes NULL pointer dereference. > > Fixes: 15381bc7c7f5 ("pinctrl: Allow configuration of pins from gpiolib based drivers") > Signed-off-by: Masahiro Yamada Acked-by: Mika Westerberg