From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751878AbdHELht (ORCPT <rfc822;w@1wt.eu>);
        Sat, 5 Aug 2017 07:37:49 -0400
Received: from verein.lst.de ([213.95.11.211]:34051 "EHLO newverein.lst.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751226AbdHELhs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 5 Aug 2017 07:37:48 -0400
Date: Sat, 5 Aug 2017 13:37:47 +0200
From: Christoph Hellwig <hch@lst.de>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: hare@suse.de, jthumshirn@suse.de, hch@lst.de, salyzyn@google.com,
        gregkh@linuxfoundation.org, Robb Glasser <rglasser@google.com>,
        Doug Gilbert <dgilbert@interlog.com>,
        "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: sg: Prevent potential double frees in sg driver
Message-ID: <20170805113747.GE16313@lst.de>
References: <20170803190248.51537-1-ndesaulniers@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170803190248.51537-1-ndesaulniers@google.com>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This looks correct and safe to me, but I wonder if anyone relies
on multi-threaded /dev/sg write usage, which would be completely
serialized with this.