From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751920AbdHGSYD (ORCPT ); Mon, 7 Aug 2017 14:24:03 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:33394 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751429AbdHGSYB (ORCPT ); Mon, 7 Aug 2017 14:24:01 -0400 Date: Mon, 07 Aug 2017 11:24:00 -0700 (PDT) Message-Id: <20170807.112400.1912794700598730100.davem@davemloft.net> To: arnd@arndb.de Cc: yisen.zhuang@huawei.com, salil.mehta@huawei.com, xavier.huwei@huawei.com, lipeng321@huawei.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hns3: fix unused function warning From: David Miller In-Reply-To: <20170807104230.3564976-1-arnd@arndb.de> References: <20170807104230.3564976-1-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 07 Aug 2017 11:24:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 7 Aug 2017 12:41:53 +0200 > Without CONFIG_PCI_IOV, we get a harmless warning about an > unused function: > > drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c:2273:13: error: 'hclge_disable_sriov' defined but not used [-Werror=unused-function] > > The #ifdefs in this driver are obviously wrong, so this just > removes them and uses an IS_ENABLED() check that does the same > thing correctly in a more readable way. > > Fixes: 46a3df9f9718 ("net: hns3: Add HNS3 Acceleration Engine & Compatibility Layer Support") > Signed-off-by: Arnd Bergmann Applied.