From: Lee Jones <lee.jones@linaro.org>
To: Hoeze <git.ich@frhoelzlwimmer.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix missing PCI ID (thanks to CoolStar); Necessary for Lenovo Yoga 720-15 Touchpad
Date: Mon, 7 Aug 2017 08:57:16 +0100 [thread overview]
Message-ID: <20170807075716.42f7cwfeosanapvk@dell> (raw)
In-Reply-To: <20170801014715.27708-1-git.ich@frhoelzlwimmer.de>
Subject line looks wrong. To see the format expected please use:
`git log --oneline -- drivers/mfd`
You are missing your SoB.
> ---
> This patch fixes a missing PCI ID which is necessary for the Lenovo Yoga 720-15 Touchpad to work.
This should be in the commit log above.
> See this bug report on Launchpad:
> https://bugs.launchpad.net/ubuntu/+source/linux/+bug/1700657
Drop external links to LP please.
> Many thanks to CoolStar, who found this solution!
This should be a "Reported-by".
Please see Documentation/SubmittingPatches' for more details.
> drivers/mfd/intel-lpss-pci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mfd/intel-lpss-pci.c b/drivers/mfd/intel-lpss-pci.c
> index 16ffeaeb1385..867df181d475 100644
> --- a/drivers/mfd/intel-lpss-pci.c
> +++ b/drivers/mfd/intel-lpss-pci.c
> @@ -208,6 +208,7 @@ static const struct pci_device_id intel_lpss_pci_ids[] = {
> { PCI_VDEVICE(INTEL, 0xa12a), (kernel_ulong_t)&spt_info },
> { PCI_VDEVICE(INTEL, 0xa160), (kernel_ulong_t)&spt_i2c_info },
> { PCI_VDEVICE(INTEL, 0xa161), (kernel_ulong_t)&spt_i2c_info },
> + { PCI_VDEVICE(INTEL, 0xa162), (kernel_ulong_t)&spt_i2c_info },
The tabbing looks wrong here.
> { PCI_VDEVICE(INTEL, 0xa166), (kernel_ulong_t)&spt_uart_info },
> /* KBL-H */
> { PCI_VDEVICE(INTEL, 0xa2a7), (kernel_ulong_t)&spt_uart_info },
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2017-08-07 7:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-01 1:47 Hoeze
2017-08-07 7:57 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170807075716.42f7cwfeosanapvk@dell \
--to=lee.jones@linaro.org \
--cc=git.ich@frhoelzlwimmer.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®