From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbdHGUmr (ORCPT ); Mon, 7 Aug 2017 16:42:47 -0400 Received: from mail-qt0-f195.google.com ([209.85.216.195]:38760 "EHLO mail-qt0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbdHGUmo (ORCPT ); Mon, 7 Aug 2017 16:42:44 -0400 Date: Tue, 8 Aug 2017 02:12:37 +0530 From: Sudip Mukherjee To: Carlos Palminha Cc: linux-kernel@vger.kernel.org, linux-parport@lists.infradead.org, sudip.mukherjee@codethink.co.uk, akpm@linux-foundation.org Subject: Re: [PATCH 1/5] parport: add newline to trailing statements Message-ID: <20170807204237.GA2880@mukherjee.sudip> References: <20170717163702.17427-1-palminha@synopsys.com> <20170717163702.17427-2-palminha@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170717163702.17427-2-palminha@synopsys.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Mon, Jul 17, 2017 at 05:36:58PM +0100, Carlos Palminha wrote: > based on checkpatch, add newline to trailing statements > > Signed-off-by: Carlos Palminha > --- > drivers/parport/daisy.c | 7 +++++-- > drivers/parport/ieee1284.c | 17 +++++++++-------- > drivers/parport/ieee1284_ops.c | 8 ++++++-- > drivers/parport/parport_cs.c | 4 +++- > drivers/parport/parport_gsc.c | 6 ++++-- > drivers/parport/probe.c | 4 +++- > 6 files changed, 30 insertions(+), 16 deletions(-) > goto try_again; > success: > parport_frob_control (port, PARPORT_CONTROL_STROBE, 0); > diff --git a/drivers/parport/parport_cs.c b/drivers/parport/parport_cs.c > index e9b52e4a4648..993565fef73b 100644 > --- a/drivers/parport/parport_cs.c > +++ b/drivers/parport/parport_cs.c > @@ -88,7 +88,9 @@ static int parport_probe(struct pcmcia_device *link) > > /* Create new parport device */ > info = kzalloc(sizeof(*info), GFP_KERNEL); > - if (!info) return -ENOMEM; > + if (!info) > + return -ENOMEM; Please use tab to indent the code. I know some part of this file uses 4 spaces to indent, so if you use one tab before 'return -ENOMEM', it will look perfect. -- Regards Sudip