From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbdHHRAi (ORCPT ); Tue, 8 Aug 2017 13:00:38 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:51568 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752059AbdHHRAh (ORCPT ); Tue, 8 Aug 2017 13:00:37 -0400 Date: Tue, 08 Aug 2017 10:00:36 -0700 (PDT) Message-Id: <20170808.100036.2179589280952142940.davem@davemloft.net> To: aviad.krawczyk@huawei.com Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bc.y@huawei.com, victor.gissin@huawei.com, zhaochen6@huawei.com, tony.qu@huawei.com Subject: Re: [PATCH V3 net-next 03/21] net-next/hinic: Initialize api cmd resources From: David Miller In-Reply-To: <912a2667-8b20-cbc2-4c32-7d34bfb6bb9b@huawei.com> References: <18d3bfccc0eb9c7da53075c6fe2ba9aa583e0bff.1501752425.git.aviad.krawczyk@huawei.com> <20170803.153513.1478323340993171697.davem@davemloft.net> <912a2667-8b20-cbc2-4c32-7d34bfb6bb9b@huawei.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Aug 2017 10:00:37 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Aviad Krawczyk Date: Tue, 8 Aug 2017 19:23:32 +0300 > Is it a new rule? It's at least 10 years old. > We can fix it, but I can look over the Linux Kernel source and there are > a lot of examples that have the same problem. Stop right there. Just because there is code in the kernel with a problem doesn't mean you can submit new code with that problem.