From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752666AbdHIEIC (ORCPT ); Wed, 9 Aug 2017 00:08:02 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:60312 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750865AbdHIEIA (ORCPT ); Wed, 9 Aug 2017 00:08:00 -0400 Date: Tue, 08 Aug 2017 21:07:59 -0700 (PDT) Message-Id: <20170808.210759.2297833203309664275.davem@davemloft.net> To: colin.king@canonical.com Cc: andrew@lunn.ch, f.fainelli@gmail.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][next] net: phy: mdio-bcm-unimac: fix unsigned wrap-around when decrementing timeout From: David Miller In-Reply-To: <20170808095232.13490-1-colin.king@canonical.com> References: <20170808095232.13490-1-colin.king@canonical.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 08 Aug 2017 21:08:00 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Colin King Date: Tue, 8 Aug 2017 10:52:32 +0100 > From: Colin Ian King > > Change post-decrement compare to pre-decrement to avoid an > unsigned integer wrap-around on timeout. This leads to the following > !timeout check to never to be true so -ETIMEDOUT is never returned. > > Detected by CoverityScan, CID#1452623 ("Logically dead code") > > Fixes: 69a60b0579a4 ("net: phy: mdio-bcm-unimac: factor busy polling loop") > Signed-off-by: Colin Ian King Applied.