From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752075AbdHHKDJ (ORCPT ); Tue, 8 Aug 2017 06:03:09 -0400 Received: from mail-wr0-f179.google.com ([209.85.128.179]:38520 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751921AbdHHKDI (ORCPT ); Tue, 8 Aug 2017 06:03:08 -0400 Date: Tue, 8 Aug 2017 11:03:04 +0100 From: Lee Jones To: Axel Lin Cc: Keerthy , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: lp87565: Convert to use devm_mfd_add_devices Message-ID: <20170808100304.fdiu35jzx5jbv5eb@dell> References: <20170730105815.26728-1-axel.lin@ingics.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170730105815.26728-1-axel.lin@ingics.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 30 Jul 2017, Axel Lin wrote: > This fixes missing mfd_remove_devices() call when unload the module. > > Signed-off-by: Axel Lin > --- > drivers/mfd/lp87565.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/lp87565.c b/drivers/mfd/lp87565.c > index 340ad0c..32d2a07 100644 > --- a/drivers/mfd/lp87565.c > +++ b/drivers/mfd/lp87565.c > @@ -73,10 +73,9 @@ static int lp87565_probe(struct i2c_client *client, > > i2c_set_clientdata(client, lp87565); > > - ret = mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, lp87565_cells, > - ARRAY_SIZE(lp87565_cells), NULL, 0, NULL); > - > - return ret; > + return devm_mfd_add_devices(lp87565->dev, PLATFORM_DEVID_AUTO, > + lp87565_cells, ARRAY_SIZE(lp87565_cells), > + NULL, 0, NULL); > } > > static const struct i2c_device_id lp87565_id_table[] = { -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog