mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: gregkh@linuxfoundation.org, jslaby@suse.com, mingo@redhat.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] scheduler: enhancement to show_state_filter
Date: Tue, 8 Aug 2017 12:24:38 +0200	[thread overview]
Message-ID: <20170808102438.teglqelqih52tnst@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CALOAHbB2k-Ks_qvb0WW_9_h1Y2=DNOHC1hWf3MgPPEqt-xT0Hg@mail.gmail.com>

On Tue, Aug 08, 2017 at 04:50:23PM +0800, Yafang Shao wrote:
> Hi Peter,
> 
> The point is we call use it as bellow,
>     show_state_filter(TASK_RUNNING);
> because TASK_RUNNING is 0, that will dump all tasks.
> 
> Under some circumstance, we need this to dump only tasks in TASK_RUNNING state.

But the patch doesn't introduce any of that. It just makes the existing
code unreadable.

  reply	other threads:[~2017-08-08 10:24 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 12:53 Yafang Shao
2017-08-08  8:30 ` Peter Zijlstra
2017-08-08  8:50   ` Yafang Shao
2017-08-08 10:24     ` Peter Zijlstra [this message]
2017-08-08 10:36       ` Yafang Shao
2017-08-08 11:04         ` Peter Zijlstra
2017-08-08 11:07           ` Yafang Shao
2017-08-08 11:24             ` Peter Zijlstra
2017-08-08 12:02               ` Yafang Shao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170808102438.teglqelqih52tnst@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.com \
    --cc=laoar.shao@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®