From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbdHHW5Y (ORCPT ); Tue, 8 Aug 2017 18:57:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38516 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751229AbdHHW5X (ORCPT ); Tue, 8 Aug 2017 18:57:23 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7065FC049D5C Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx07.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=jglisse@redhat.com From: jglisse@redhat.com To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Davidlohr Bueso , Andrew Morton Subject: [PATCH] mm/mmu_notifier: fix deadlock from typo vm_lock_anon_vma() Date: Tue, 8 Aug 2017 18:57:19 -0400 Message-Id: <20170808225719.20723-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 08 Aug 2017 22:57:23 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jérôme Glisse Fix typo introduced by 0c67e6038580e343bd5af12b7ac6548634f05f0d which result in dead lock when mm_take_all_locks() is call (only user being mmu_notifier at this time) Signed-off-by: Jérôme Glisse Cc: Davidlohr Bueso Cc: Andrew Morton --- mm/mmap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/mmap.c b/mm/mmap.c index 74abfd382478..2d906a8f67ac 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -3314,7 +3314,7 @@ static DEFINE_MUTEX(mm_all_locks_mutex); static void vm_lock_anon_vma(struct mm_struct *mm, struct anon_vma *anon_vma) { - if (!test_bit(0, (unsigned long *) &anon_vma->rb_root.rb_root.rb_node)) { + if (!test_bit(0, (unsigned long *) &anon_vma->root->rb_root.rb_root.rb_node)) { /* * The LSB of head.next can't change from under us * because we hold the mm_all_locks_mutex. -- 2.13.4