From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752439AbdHIFcK (ORCPT ); Wed, 9 Aug 2017 01:32:10 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:44039 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750830AbdHIFcI (ORCPT ); Wed, 9 Aug 2017 01:32:08 -0400 X-ME-Sender: X-Sasl-enc: jXqTsbzf/oHhWK/4Nur6OiApP1eu4FX4Al3uDB2kC5T2 1502256727 From: Dima Kogan To: Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org Cc: Dima Kogan Subject: [PATCH] perf: Util.py add_stats() computes the mean correctly Date: Tue, 8 Aug 2017 22:31:49 -0700 Message-Id: <20170809053149.14092-1-dima@secretsauce.net> X-Mailer: git-send-email 2.13.3 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org add_stats() is a utility function for perf scripts to accumulate a value, and keep track of some statistics. The mean is one of the statistics it keeps track of, but due to a bug, this wasn't being computed properly. This patch makes the computation correct Signed-off-by: Dima Kogan --- tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py index 1d95009592eb..3d1f08b8ba19 100644 --- a/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py +++ b/tools/perf/scripts/python/Perf-Trace-Util/lib/Perf/Trace/Util.py @@ -41,7 +41,7 @@ def add_stats(dict, key, value): min = value if value > max: max = value - avg = (avg + value) / 2 + avg = (avg*count + float(value)) / (count + 1) dict[key] = (min, max, avg, count + 1) def clear_term(): -- 2.11.0