mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Catalin Marinas <catalin.marinas@arm.com>
To: Dmitry Safonov <dsafonov@virtuozzo.com>
Cc: linux-kernel@vger.kernel.org, 0x7f454c46@gmail.com,
	Will Deacon <will.deacon@arm.com>,
	Russell King <rmk+kernel@armlinux.org.uk>,
	Christopher Covington <cov@codeaurora.org>,
	Cyrill Gorcunov <gorcunov@openvz.org>,
	linux-arm-kernel@lists.infradead.org,
	Pavel Emelyanov <xemul@virtuozzo.com>
Subject: Re: [PATCH] arm64/vdso: Support mremap() for vDSO
Date: Wed, 9 Aug 2017 11:13:41 +0100	[thread overview]
Message-ID: <20170809101341.j7qvffmkgaxtfapb@armageddon.cambridge.arm.com> (raw)
In-Reply-To: <20170726170737.21696-1-dsafonov@virtuozzo.com>

On Wed, Jul 26, 2017 at 08:07:37PM +0300, Dmitry Safonov wrote:
> vDSO VMA address is saved in mm_context for the purpose of using
> restorer from vDSO page to return to userspace after signal handling.
> 
> In Checkpoint Restore in Userspace (CRIU) project we place vDSO VMA
> on restore back to the place where it was on the dump.
> With the exception for x86 (where there is API to map vDSO with
> arch_prctl()), we move vDSO inherited from CRIU task to restoree
> position by mremap().
> 
> CRIU does support arm64 architecture, but kernel doesn't update
> context.vdso pointer after mremap(). Which results in translation
> fault after signal handling on restored application:
> https://github.com/xemul/criu/issues/288
> 
> Make vDSO code track the VMA address by supplying .mremap() fops
> the same way it's done for x86 and arm32 by:
> commit b059a453b1cf ("x86/vdso: Add mremap hook to vm_special_mapping")
> commit 280e87e98c09 ("ARM: 8683/1: ARM32: Support mremap() for sigpage/vDSO").
> 
> Cc: Catalin Marinas <catalin.marinas@arm.com>
> Cc: Will Deacon <will.deacon@arm.com>
> Cc: Russell King <rmk+kernel@armlinux.org.uk>
> Cc: linux-arm-kernel@lists.infradead.org
> Cc: Cyrill Gorcunov <gorcunov@openvz.org>
> Cc: Pavel Emelyanov <xemul@virtuozzo.com>
> Cc: Christopher Covington <cov@codeaurora.org>
> Signed-off-by: Dmitry Safonov <dsafonov@virtuozzo.com>

Queued for 4.14. Thanks.

-- 
Catalin

      parent reply	other threads:[~2017-08-09 10:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-26 17:07 Dmitry Safonov
2017-07-28 16:48 ` Will Deacon
2017-07-28 19:06   ` Dmitry Safonov
2017-08-02 16:04     ` Will Deacon
2017-08-08  9:29       ` Dmitry Safonov
2017-08-08  9:44         ` Will Deacon
2017-08-08 17:02           ` Dmitry Safonov
2017-08-09 10:13 ` Catalin Marinas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809101341.j7qvffmkgaxtfapb@armageddon.cambridge.arm.com \
    --to=catalin.marinas@arm.com \
    --cc=0x7f454c46@gmail.com \
    --cc=cov@codeaurora.org \
    --cc=dsafonov@virtuozzo.com \
    --cc=gorcunov@openvz.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rmk+kernel@armlinux.org.uk \
    --cc=will.deacon@arm.com \
    --cc=xemul@virtuozzo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®