From: Peter Zijlstra <peterz@infradead.org>
To: Vince Weaver <vincent.weaver@maine.edu>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Stephane Eranian <eranian@gmail.com>
Subject: Re: [patch] perf wrong enabled time after attach/enable/enable
Date: Wed, 9 Aug 2017 18:30:59 +0200 [thread overview]
Message-ID: <20170809163059.zyd4sgbuylrmhq3r@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20170804112253.vk4rg334732f4s7x@hirez.programming.kicks-ass.net>
On Fri, Aug 04, 2017 at 01:22:53PM +0200, Peter Zijlstra wrote:
> On Thu, Aug 03, 2017 at 02:07:53PM -0400, Vince Weaver wrote:
> > On Wed, 2 Aug 2017, Peter Zijlstra wrote:
> >
> > > Playing with that test it really is the IOC_DISABLE while STOP'ed that
> > > messes things up.
> > >
> > > Ah.. magic.. the below seems to fix things, hopefully it doesn't break
> > > anything else.
> >
> > yes, I've tested this and it seems to fix things.
>
> New version below.. is a bit different and should handle another case.
> I'll try and run more tests on it, because while it _SHOULD_ not trigger
> that WARN_ON_ONCE() you know how that goes..
And splat it goes.. turns out we can attach to a ctx when OFF (which
makes sense, they need to live someplace too).
In that case the IOC_ENABLE will again go through
__perf_event_enable_time() and recompute things.
I think I'll just remove the WARN_ON_ONCE(), and put in a comment.
prev parent reply other threads:[~2017-08-09 16:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-26 1:47 Vince Weaver
2017-08-02 17:10 ` Peter Zijlstra
2017-08-03 18:07 ` Vince Weaver
2017-08-04 11:22 ` Peter Zijlstra
2017-08-04 13:35 ` Vince Weaver
2017-08-09 16:30 ` Peter Zijlstra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170809163059.zyd4sgbuylrmhq3r@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=acme@kernel.org \
--cc=eranian@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=vincent.weaver@maine.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®