From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753148AbdHIQek (ORCPT ); Wed, 9 Aug 2017 12:34:40 -0400 Received: from mail-wm0-f65.google.com ([74.125.82.65]:37570 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752260AbdHIQej (ORCPT ); Wed, 9 Aug 2017 12:34:39 -0400 Date: Wed, 9 Aug 2017 19:34:34 +0300 From: "Kirill A. Shutemov" To: jglisse@redhat.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, "Kirill A . Shutemov" , Andrew Morton Subject: Re: [PATCH] mm/rmap: try_to_unmap_one() do not call mmu_notifier under ptl Message-ID: <20170809163434.p356oyarqpqh52hu@node.shutemov.name> References: <20170809161709.9278-1-jglisse@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170809161709.9278-1-jglisse@redhat.com> User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 09, 2017 at 12:17:09PM -0400, jglisse@redhat.com wrote: > From: Jérôme Glisse > > MMU notifiers can sleep, but in try_to_unmap_one() we call > mmu_notifier_invalidate_page() under page table lock. > > Let's instead use mmu_notifier_invalidate_range() outside > page_vma_mapped_walk() loop. > > Signed-off-by: Jérôme Glisse > Cc: Kirill A. Shutemov > Cc: Andrew Morton > Fixes: c7ab0d2fdc84 ("mm: convert try_to_unmap_one() to use page_vma_mapped_walk()") > --- > mm/rmap.c | 36 +++++++++++++++++++++--------------- > 1 file changed, 21 insertions(+), 15 deletions(-) > > diff --git a/mm/rmap.c b/mm/rmap.c > index aff607d5f7d2..d60e887f1cda 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1329,7 +1329,8 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma, > }; > pte_t pteval; > struct page *subpage; > - bool ret = true; > + bool ret = true, invalidation_needed = false; > + unsigned long end = address + PAGE_SIZE; I think it should be 'address + (1UL << compound_order(page))'. -- Kirill A. Shutemov