mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@kernel.org>
To: Daniel Mentz <danielmentz@google.com>
Cc: linux-kernel@vger.kernel.org,
	"Luis R . Rodriguez" <mcgrof@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] kmod: test_kmod: Correctly lock reg_dev_mutex
Date: Wed, 9 Aug 2017 21:29:40 +0200	[thread overview]
Message-ID: <20170809192940.GI27873@wotan.suse.de> (raw)
In-Reply-To: <20170808232733.28415-1-danielmentz@google.com>

On Tue, Aug 08, 2017 at 04:27:33PM -0700, Daniel Mentz wrote:
> It appears that, in the preamble of register_test_dev_kmod(),
> mutex_lock() has been confused with mutex_unlock().
> 
> Previously, register_test_dev_kmod() never called mutex_lock() but
> instead, it called mutex_unlock() twice.
> 
> Signed-off-by: Daniel Mentz <danielmentz@google.com>
> Cc: Luis R. Rodriguez <mcgrof@kernel.org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> ---

Thanks Daniel but someone beat you to the fix, I've sent this to Andrew
and he's integrated into his -mm tree. See:

http://lkml.kernel.org/r/20170802211450.27928-5-mcgrof@kernel.org

This series had other fixes:

https://marc.info/?l=linux-kernel&m=150170850624962&w=2

I'll CC you on other kmod / test_kmod changes.

 Luis

  reply	other threads:[~2017-08-09 19:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-08 23:27 Daniel Mentz
2017-08-09 19:29 ` Luis R. Rodriguez [this message]
2017-08-09 21:56   ` Daniel Mentz
2017-08-09 22:35     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170809192940.GI27873@wotan.suse.de \
    --to=mcgrof@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=danielmentz@google.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome