From: Dan Carpenter <dan.carpenter@oracle.com>
To: Phil Elwell <phil@raspberrypi.org>
Cc: Eric Anholt <eric@anholt.net>,
Stefan Wahren <stefan.wahren@i2se.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Florian Fainelli <f.fainelli@gmail.com>,
Aishwarya Pant <aishpant@gmail.com>,
linux-rpi-kernel@lists.infradead.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: bcm2835-audio: Fix memory corruption
Date: Thu, 10 Aug 2017 14:05:53 +0300 [thread overview]
Message-ID: <20170810110553.eavfnl6bi4cpei2s@mwanda> (raw)
In-Reply-To: <b88ad53c-0bd3-804e-d1db-3561fd05a850@raspberrypi.org>
On Thu, Aug 10, 2017 at 11:52:42AM +0100, Phil Elwell wrote:
> > This label name is out of date. There is a later error path where
> > vc_vchi_audio_init() fails and we leak on that path.
>
> Also agreed. I'll rework it.
>
Actually I wasn't right. That error path should probably stay how it
is, because we're re-using the vchi_instance. We allocate it in the
first call then re-use it later.
This code is really subtle and ugly.
regards,
dan carpenter
next prev parent reply other threads:[~2017-08-10 11:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-08 12:05 Phil Elwell
2017-08-10 10:21 ` Dan Carpenter
2017-08-10 10:52 ` Phil Elwell
2017-08-10 11:05 ` Dan Carpenter [this message]
2017-08-10 11:24 ` Dan Carpenter
2017-08-10 11:33 ` Dan Carpenter
2017-08-10 13:25 ` Phil Elwell
2017-08-10 14:07 ` Dan Carpenter
2017-08-11 9:57 Phil Elwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170810110553.eavfnl6bi4cpei2s@mwanda \
--to=dan.carpenter@oracle.com \
--cc=aishpant@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=eric@anholt.net \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=phil@raspberrypi.org \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®