From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752904AbdHJRFM (ORCPT ); Thu, 10 Aug 2017 13:05:12 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:33557 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbdHJRFK (ORCPT ); Thu, 10 Aug 2017 13:05:10 -0400 Date: Thu, 10 Aug 2017 12:05:08 -0500 From: Rob Herring To: Frank Wang Cc: heiko@sntech.de, kishon@ti.com, mark.rutland@arm.com, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, huangtao@rock-chips.com, william.wu@rock-chips.com, daniel.meng@rock-chips.com, kever.yang@rock-chips.com, andy.yan@rock-chips.com, wmc@rock-chips.com Subject: Re: [PATCH v3 2/5] dt-bindings: phy-rockchip-inno-usb2: add companion grf quirk Message-ID: <20170810170508.pwf35mud4ffnrzzd@rob-hp-laptop> References: <1501747753-6983-1-git-send-email-frank.wang@rock-chips.com> <1501747753-6983-3-git-send-email-frank.wang@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501747753-6983-3-git-send-email-frank.wang@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 03, 2017 at 04:09:10PM +0800, Frank Wang wrote: > Add rockchip,usbgrf and rockchip,companion_grf_quirk to support > the registers of usb-phy that are distributed in grf and usbgrf > on some special Rockchip SoCs (e.g RV1108). > > Signed-off-by: Frank Wang > --- > Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > index 84d59b0..ddf868a 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-inno-usb2.txt > @@ -18,6 +18,10 @@ Optional properties: > usb-phy output 480m and xin24m. > Refer to clk/clock-bindings.txt for generic clock > consumer properties. > + - rockchip,usbgrf : phandle to the syscon managing the "usb general > + register files". > + - rockchip,companion_grf_quirk : when set driver will request > + "rockchip,usbgrf" phandle as one companion-grf. Why isn't presence of rockchip,usbgrf or being implied by an SoC specific compatible string enough? In any case, use '-' rather than '_'. > > Required nodes : a sub-node is required for each port the phy provides. > The sub-node name is used to identify host or otg port, > -- > 2.0.0 > >