mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Petr Mladek <pmladek@suse.com>,
	Sergey Senozhatsky <sergey.senozhatsky@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	linux-kernel@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: [PATCH] printk-formats.txt: Add examples for %pS and %pF
Date: Thu, 10 Aug 2017 19:35:33 +0200	[thread overview]
Message-ID: <20170810173533.GA11600@ls3530.fritz.box> (raw)

Sometimes people seems unclear when to use the %pS or %pF printk format.
Adding some examples may help to avoid such mistakes.

See for example commit 51d96dc2e2dc ("random: fix warning message on ia64 and
parisc") which fixed such a wrong format string.

Signed-off-by: Helge Deller <deller@gmx.de>

diff --git a/Documentation/printk-formats.txt b/Documentation/printk-formats.txt
index 65ea591..be8c05b 100644
--- a/Documentation/printk-formats.txt
+++ b/Documentation/printk-formats.txt
@@ -73,6 +73,12 @@ actually function descriptors which must first be resolved. The ``F`` and
 ``f`` specifiers perform this resolution and then provide the same
 functionality as the ``S`` and ``s`` specifiers.
 
+Examples::
+
+	printk("Called from %pS.\n", __builtin_return_address(0));
+	printk("Called from %pS.\n", (void *)regs->ip);
+	printk("Called from %pF.\n", &gettimeofday);
+
 Kernel Pointers
 ===============
 

             reply	other threads:[~2017-08-10 17:36 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-08-10 17:35 Helge Deller [this message]
2017-08-11  0:15 ` Sergey Senozhatsky
2017-08-11  7:31   ` Helge Deller
2017-08-15 11:36     ` Petr Mladek
2017-08-15 19:58       ` Helge Deller
2017-08-23 14:48         ` Petr Mladek
2017-08-23 14:49           ` Steven Rostedt
2017-08-23 19:36             ` Helge Deller
2017-08-24  9:21               ` Petr Mladek
2017-08-24  0:41           ` Sergey Senozhatsky
2017-08-24  2:11             ` Steven Rostedt
2017-08-16  8:14       ` Sergey Senozhatsky
2017-08-15 12:46 ` Steven Rostedt
2017-08-15 19:41   ` Helge Deller
2017-08-15 19:47     ` Helge Deller
2017-08-15 21:35       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170810173533.GA11600@ls3530.fritz.box \
    --to=deller@gmx.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=pmladek@suse.com \
    --cc=rostedt@goodmis.org \
    --cc=sergey.senozhatsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®