From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753561AbdHKScq (ORCPT ); Fri, 11 Aug 2017 14:32:46 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:36098 "EHLO mail-pg0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752883AbdHKScp (ORCPT ); Fri, 11 Aug 2017 14:32:45 -0400 Date: Fri, 11 Aug 2017 11:32:43 -0700 From: Matthias Kaehlcke To: Daniel Vetter , Jani Nikula , David Airlie , Daniel Vetter , Manasi Navare , rodrigo.vivi@intel.com, clinton.a.taylor@intel.com Cc: intel-gfx , dri-devel@lists.freedesktop.org, Linux Kernel Mailing List , =?utf-8?B?U3TDqXBoYW5l?= Marchesin , Grant Grundler Subject: Re: [PATCH v2] drm/i915: Return correct EDP voltage swing table for 0.85V Message-ID: <20170811183243.GB109008@google.com> References: <20170717195854.192139-1-mka@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170717195854.192139-1-mka@chromium.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org El Mon, Jul 17, 2017 at 12:58:54PM -0700 Matthias Kaehlcke ha dit: > For 0.85V cnl_get_buf_trans_edp() returns the DP table, instead of EDP. > Use the correct table. > > The error was pointed out by this clang warning: > > drivers/gpu/drm/i915/intel_ddi.c:392:39: warning: variable > 'cnl_ddi_translations_edp_0_85V' is not needed and will not be emitted > [-Wunneeded-internal-declaration] > static const struct cnl_ddi_buf_trans cnl_ddi_translations_edp_0_85V[] = { > > Fixes: cf54ca8bc567 ("drm/i915/cnl: Implement voltage swing sequence.") > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Manasi Navare > --- > Changes in v2: > - Added 'Fixes' tag > - Added Reviewed-by: Manasi Navare ping, it seems this patch went under the radar.