From: Denys Vlasenko <dvlasenk@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Denys Vlasenko <dvlasenk@redhat.com>,
mingo@redhat.com, Jim Kukunas <james.t.kukunas@linux.intel.com>,
Fenghua Yu <fenghua.yu@intel.com>,
Megha Dey <megha.dey@linux.intel.com>,
Gayatri Kammela <gayatri.kammela@intel.com>,
Shaohua Li <shli@fb.com>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] lib/raid6: align AVX512 constants to 512 bits, not bytes
Date: Sat, 12 Aug 2017 19:43:46 +0200 [thread overview]
Message-ID: <20170812174346.12025-1-dvlasenk@redhat.com> (raw)
Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: mingo@redhat.com
Cc: Jim Kukunas <james.t.kukunas@linux.intel.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>
Cc: Megha Dey <megha.dey@linux.intel.com>
Cc: Gayatri Kammela <gayatri.kammela@intel.com>
Cc: Shaohua Li <shli@fb.com>
Cc: x86@kernel.org
Cc: linux-kernel@vger.kernel.org
---
avx512.o before:
Sections:
Idx Name Size VMA LMA File off Algn
4 .rodata 00000240 0000000000000000 0000000000000000 00000c00 2**9
CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
...
Contents of section .rodata:
0000 00000000 00000000 00000000 00000000 ................
0010 00000000 00000000 00000000 00000000 ................
0020 01000000 00000000 00000000 00000000 ................
0030 00000000 00000000 00000000 00000000 ................
0040 00000000 00000000 00000000 00000000 ................
0050 00000000 00000000 00000000 00000000 ................
0060 01000000 00000000 00000000 00000000 ................
0070 00000000 00000000 00000000 00000000 ................
0080 00000000 00000000 00000000 00000000 ................
0090 00000000 00000000 00000000 00000000 ................
00a0 01000000 00000000 00000000 00000000 ................
00b0 00000000 00000000 00000000 00000000 ................
00c0 00000000 00000000 00000000 00000000 ................
00d0 00000000 00000000 00000000 00000000 ................
00e0 00000000 00000000 00000000 00000000 ................
00f0 00000000 00000000 00000000 00000000 ................
0100 00000000 00000000 00000000 00000000 ................
0110 00000000 00000000 00000000 00000000 ................
0120 00000000 00000000 00000000 00000000 ................
0130 00000000 00000000 00000000 00000000 ................
0140 00000000 00000000 00000000 00000000 ................
0150 00000000 00000000 00000000 00000000 ................
0160 00000000 00000000 00000000 00000000 ................
0170 00000000 00000000 00000000 00000000 ................
0180 00000000 00000000 00000000 00000000 ................
0190 00000000 00000000 00000000 00000000 ................
01a0 00000000 00000000 00000000 00000000 ................
01b0 00000000 00000000 00000000 00000000 ................
01c0 00000000 00000000 00000000 00000000 ................
01d0 00000000 00000000 00000000 00000000 ................
01e0 00000000 00000000 00000000 00000000 ................
01f0 00000000 00000000 00000000 00000000 ................
0200 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
0210 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
0220 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
0230 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
avx512.o after:
Sections:
Idx Name Size VMA LMA File off Algn
4 .rodata 00000100 0000000000000000 0000000000000000 00000b40 2**6
CONTENTS, ALLOC, LOAD, RELOC, READONLY, DATA
...
Contents of section .rodata:
0000 00000000 00000000 00000000 00000000 ................
0010 00000000 00000000 00000000 00000000 ................
0020 01000000 00000000 00000000 00000000 ................
0030 00000000 00000000 00000000 00000000 ................
0040 00000000 00000000 00000000 00000000 ................
0050 00000000 00000000 00000000 00000000 ................
0060 01000000 00000000 00000000 00000000 ................
0070 00000000 00000000 00000000 00000000 ................
0080 00000000 00000000 00000000 00000000 ................
0090 00000000 00000000 00000000 00000000 ................
00a0 01000000 00000000 00000000 00000000 ................
00b0 00000000 00000000 00000000 00000000 ................
00c0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
00d0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
00e0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
00f0 1d1d1d1d 1d1d1d1d 1d1d1d1d 1d1d1d1d ................
lib/raid6/avx512.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/raid6/avx512.c b/lib/raid6/avx512.c
index f524a79..46df797 100644
--- a/lib/raid6/avx512.c
+++ b/lib/raid6/avx512.c
@@ -29,7 +29,7 @@
static const struct raid6_avx512_constants {
u64 x1d[8];
-} raid6_avx512_constants __aligned(512) = {
+} raid6_avx512_constants __aligned(512/8) = {
{ 0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
0x1d1d1d1d1d1d1d1dULL, 0x1d1d1d1d1d1d1d1dULL,
--
2.9.2
next reply other threads:[~2017-08-12 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-12 17:43 Denys Vlasenko [this message]
2017-08-14 16:18 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170812174346.12025-1-dvlasenk@redhat.com \
--to=dvlasenk@redhat.com \
--cc=fenghua.yu@intel.com \
--cc=gayatri.kammela@intel.com \
--cc=hpa@zytor.com \
--cc=james.t.kukunas@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=megha.dey@linux.intel.com \
--cc=mingo@redhat.com \
--cc=shli@fb.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®